Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6248 Improvement: Set foundation to improve migrate-to-typescript efficiency #6249

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tylers-username
Copy link
Contributor

Changes
Resolves #6248.

  • Adds typescript and webpack aliases
  • Configures eslint to understand the aliases
  • Refactors src/index.jsx to src/index.tsx and declares webSettings.d.ts and another modeule to serve as an example of how the migration to typescript can be done iteratively

Issues

@tylers-username tylers-username requested a review from a team as a code owner October 24, 2024 12:49
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 24, 2024

Cloudflare Pages deployment

Latest commit b988d62
Status ✅ Deployed!
Preview URL https://4fed4f22.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/global.d.ts Outdated Show resolved Hide resolved
src/types/assets.d.ts Outdated Show resolved Hide resolved
src/types/window.d.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Set foundation to improve migrate-to-typescript efficiency
2 participants